Skip to content

Removing FF guard for canListenToDownloadWillBeginEvent #16439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

Removing FF guard for canListenToDownloadWillBeginEvent #16439

merged 3 commits into from
Oct 15, 2025
+2 −3

Conversation

diemol
Copy link
Member

@diemol diemol commented Oct 15, 2025 •
edited by qodo-merge-pro bot
Loading

User description

This test is now passing in Firefox

PR Type

Tests

Description

  • Removed Firefox guard from canListenToDownloadWillBeginEvent test

  • Test now passes in Firefox browser

Diagram Walkthrough

flowchart LR
  A["Test Method"] --> B["Remove @NotYetImplemented"]
  B --> C["Firefox Support Enabled"]
Loading

File Walkthrough
Relevant files
Tests
BrowsingContextInspectorTest.java
Enable download event test for Firefox                                     

java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java

  • Removed @NotYetImplemented(FIREFOX) annotation from test method
  • Enables canListenToDownloadWillBeginEvent test for Firefox execution
 +0/-1     

@selenium-ci selenium-ci added C-java Java Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Oct 15, 2025
@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 15, 2025 •
edited
Loading

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided 
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
⚪
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

qodo-merge-pro bot commented Oct 15, 2025 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@diemol diemol merged commit b82c2e1 into trunk Oct 15, 2025
27 of 28 checks passed
@diemol diemol deleted the remove_ff_not_yet_implemented branch October 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B-devtools Includes everything BiDi or Chrome DevTools related C-java Java Bindings Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diemol @selenium-ci